On 4/24/2024 2:52 PM, 'Albrecht Schlosser' via fltk.coredev wrote:

On 4/24/24 19:14 Gonzalo Garramuño wrote:

A user of my program reported random crashes when working, which I cannot reproduce.  I managed to get a stack trace from him, but not much more information yet.  The relevant information follows.  Any help is appreciated.

Okay.  Here's the real stack trace that points to a bug in FLTK:

0: mrv::callback - 0x140701647072160 (C:\code\mrv2\mrv2\lib\mrvCore\win32\mrvSignalHandler.cpp:37)
1: log2f - 0x140705404926352 (line number unavailable)
2: `__scrt_common_main_seh'::`1'::filt$0 - 0x140701651910942 (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:304)
3: _C_specific_handler - 0x140705005169712 (line number unavailable)
4: _chkstk - 0x140705442906848 (line number unavailable)
5: RtlFindCharInUnicodeString - 0x140705442355664 (line number unavailable)
6: KiUserExceptionDispatcher - 0x140705442902992 (line number unavailable)
7: Fl_Window::handle - 0x140701644897184 (C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\Fl_Window.cxx:595)
8: Fl_Window_Driver::hide_common - 0x140701644960032 (C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\Fl_Window_Driver.cxx:173)
9: Fl_WinAPI_Window_Driver::hide - 0x140701645080560 (C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\drivers\WinAPI\Fl_WinAPI_Window_Driver.cxx:470)
10: Fl_Timeout::do_timeouts - 0x140701644961840 (C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\Fl_Timeout.cxx:490)
11: Fl_System_Driver::wait - 0x140701645030560 (C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\Fl_System_Driver.cxx:360)
12: Fl_WinAPI_System_Driver::wait - 0x140701645075376 (C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\Fl_win32.cxx:362)
13: Fl::run - 0x140701644884672 (C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\Fl.cxx:605)
14: main - 0x140701644700128 (C:\code\mrv2\mrv2\src\main.cpp:70)
15: WinMain - 0x140701644699808 (C:\code\mrv2\mrv2\src\main.cpp:125)
16: __scrt_common_main_seh - 0x140701651483248 (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
17: BaseThreadInitThunk - 0x140705406854496 (line number unavailable)
18: RtlUserThreadStart - 0x140705442605600 (line number unavailable)


GIT TAG is eeed39524606f1717dd2634ffe52e4640a606841

C:\code\mrv2\BUILD-Msys-amd64-small\Release\FLTK-prefix\src\FLTK\src\Fl_Window.cxx:595

is:
            Fl_Widget* p = parent(); for (;p->visible();p = p->parent()) {}

it should be:

            Fl_Widget* p = parent(); for (;p && p->visible();p = p->parent()) {}

-- 
Gonzalo Garramuño
ggarra13@gmail.com

Actually, the fix should be these two lines:

            Fl_Widget* p = parent(); for (p && ;p->visible();p = p->parent()) {}
            if (!p || p->type() >= FL_WINDOW) break; // don't do the unmap

-- 
Gonzalo Garramuño
ggarra13@gmail.com