On 5/7/24 02:39 Daniel Harding wrote:

FTR, if it was changed such that 0 out of 12 themes had their selected menu
background color "flipped" to white (as opposed to 2 out of 12 being
flipped in FLTK 1.3.8), I think that would be even better. (I'm not
striving for backwards compatibility per se.)

As already said, this will be investigated further.

I think it would make sense
for it the be the user's responsibility to ensure the current selection
color contrasts adequately with the current background color and then in
turn FLTK always honored the selection color, as is being discussed in the
github issue. In other words, perhaps the new contrast function isn't too
aggressive at all -- just not needed in this case.

Unfortunately it's not possible to select adequately contrasting colors
by the program developer. Users of the program can run them on a variety
of systems and use a variety of system "themes" (KDE, Gnome, other DE's)
and FLTK always tries to honor the system "theme", i.e. the background
and selection colors. This is why you see the different colors in issue
#969 posted by Manolo. In fact I had to *introduce* another call to
fl_contrast() somewhere recently (may be some months ago) where a user
reported that the system's background color and selection color were the
same which obviously didn't work well.

Therefore fl_contrast() *must* be used in several places, but (I'm
repeating myself) the current usage that flips the color of the selected
menu item may be wrong. Some code in FLTK is pretty old and may have
undiscovered issues like this which depend highly on the system environment.

But again, we'll check this.

--
You received this message because you are subscribed to the Google Groups "fltk.general" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkgeneral+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkgeneral/6bcfd3e2-0f40-4dea-b552-9079308cbe16%40aljus.de.