| [ Return to Bugs & Features | Roadmap 1.3 | SVN ⇄ GIT ]
STR #1922
Application: | FLTK Library |
Status: | 1 - Closed w/Resolution |
Priority: | 2 - Low, e.g. a documentation error or undocumented side-effect |
Scope: | 3 - Applies to all machines and operating systems |
Subsystem: | Build Files |
Summary: | src/Makefile has hardcoded libfltk*.so.1.3 |
Version: | 1.3-current |
Created By: | alvin |
Assigned To: | AlbrechtS |
Fix Version: | 1.3.4 (SVN: v10609) |
Update Notification: | |
Trouble Report Files:
Trouble Report Comments:
|
#1 | alvin 10:46 Apr 18, 2008 |
| The src/Makefile found in fltk-1.3.x-r6101 has hardcoded version number, 1.1, as the make targets rather than using the variables defined in makeinclude.
This prevents the libfltk.so.1.3 (and others) from compiling.
I have attached a patch that corrects the problem by using the DSONAME, FLDSONAME, GLDSONAME, IMGDSONAME variables. However, there are other instances in src/Makefile that the 1.1 does occur. However, these are for target OSes that I cannot test the patch against.
In the install and uninstall targets (src/Makefile), a test is done to check if DSONAME (and others) matches the string "libfltk.so.1.1" (and others). I have replaced the 1.1 with 1.3 as this test seems to require the literal name. I have done this for only the .so tests and not the .s1 or .dll as I do not use these ;) Perhaps someone who does use these can make the appropriate changes.
Perhaps the hardcoded version number, 1.3, should be replaced with the variable VERSION or something to that effect?
Also, upon closer inspection of the install target, there seems to be almost no difference between the various test cases when it comes to each variable (e.g. DSNOAME). This seems to suggest that all the DSONAME tests under the install target could be merged (this applies to FLDSONAME, etc. too)? | |
|
#2 | matt 13:11 Apr 23, 2008 |
| Hardcoded to 1.3. Eventually this should be using the matching variables. | |
|
#3 | matt 13:59 Jan 01, 2009 |
| This is currenntly not possible considering the way the Makefiles are set up. Pushing this up. | |
|
#4 | AlbrechtS 06:49 Mar 10, 2015 |
| Fixed in Subversion repository.
Note: previous "Fix Version" was r 6115: "Changed Makefile in src to use 1.3 instead of 1.1".
I tried to fix the issue to get rid of library versions in Makefile's in svn r 10609 by replacing all occurrences of version numbers with those given by configure (in makeinclude). This is different than the OP's patch though.
Now that I saw the discussion in this STR I'm wondering if I missed something... I'm not sure what Matt meant in comment #3.
@OP (Alvin): Can you confirm this works as expected? | |
|
#5 | alvin 09:34 Mar 10, 2015 |
| Using a vanilla build[1], I confirm that the shared libraries build correctly on GNU/Linux:
.../src> ls -1 *.so* libfltk_forms.so libfltk_forms.so.1.3 libfltk_gl.so libfltk_gl.so.1.3 libfltk_images.so libfltk_images.so.1.3 libfltk.so libfltk.so.1.3
[1] vanilla build: make include; ./configure --enable-shared; make | |
|
#6 | alvin 09:39 Mar 10, 2015 |
| Should have added that my previous message is for SVN r10613. | |
|
#7 | AlbrechtS 09:44 Mar 10, 2015 |
| Thanks for confirmation.
If nobody else reports any issues I'll close this STR in a few days. | |
[ Return to Bugs & Features ]
|
| |