| [ Return to Bugs & Features | Roadmap 1.3 | SVN ⇄ GIT ]
STR #2907
Application: | FLTK Library |
Status: | 1 - Closed w/Resolution |
Priority: | 3 - Moderate, e.g. unable to compile the software |
Scope: | 3 - Applies to all machines and operating systems |
Subsystem: | Core Library |
Summary: | deactivated box appearance |
Version: | 1.3-current |
Created By: | corvid |
Assigned To: | AlbrechtS |
Fix Version: | 1.3.4 (SVN: v10781) |
Update Notification: | |
Trouble Report Files:
No files
Trouble Report Comments:
|
#1 | corvid 11:58 Dec 15, 2012 |
| I wrote to fltk.general about five days ago and got no response. I'll paste it in here so that it can't slip between the cracks permanently:
I was playing around with the Fl_Light_Button colors as brought up the other day, and I noticed how the round button or something didn't grey out when deactivated in the gtk+ scheme. Hmmm....
I went off to test/boxtype and tried
Index: boxtype.cxx =================================================================== --- boxtype.cxx (revision 9746) +++ boxtype.cxx (working copy) @@ -37,6 +37,8 @@ y = y*H+10; Fl_Box *b = new Fl_Box(type,x,y,square ? H-20 : W-20,H-20,name); b->labelsize(11); + b->color(FL_RED); + b->deactivate(); if (square) b->align(FL_ALIGN_RIGHT); }
...and the ones that stayed bright red seemed like an arbitrary assortment.
Is this in some way proper behaviour for these boxtypes?
If not, I can try to make a patch modeled on how fl_gtk.cxx deals with it. | |
|
#2 | ianmacarthur 15:40 Sep 04, 2014 |
| Does anyone know if this still happens?
Can anyone reproduce this? | |
|
#3 | corvid 17:05 Sep 04, 2014 |
| Looks to me like the situation has not changed. | |
|
#4 | AlbrechtS 17:19 Jul 08, 2015 |
| Fixed in Subversion repository.
Box drawing code has been fixed.
Test code similar to the proposed code has been added to test/boxtypes.cxx in svn r 10780:
+static const int inactive = 0; // deactivate boxes and use green background
Activate the test code by setting "inactive = 1;" (ca. line # 52).
I tested it with all box types and all schemes and didn't see any wrong colors.
Please test and report if you can still see wrong colors or if this fixes the issue. Thanks. | |
|
#5 | corvid 20:03 Jul 08, 2015 |
| Looks good! | |
|
#6 | AlbrechtS 07:54 Jul 09, 2015 |
| Thanks for confirmation. Closing this STR now. | |
[ Return to Bugs & Features ]
|
| |