| | [ Return to Bugs & Features | Roadmap 1.3 | SVN ⇄ GIT ]
STR #2997
| Application: | FLTK Library |
|---|
| Status: | 1 - Closed w/Resolution |
|---|
| Priority: | 1 - Request for Enhancement, e.g. asking for a feature |
|---|
| Scope: | 3 - Applies to all machines and operating systems |
|---|
| Subsystem: | FLUID |
|---|
| Summary: | fluid: various desired features |
|---|
| Version: | 1.3-feature |
|---|
| Created By: | greg.ercolano |
|---|
| Assigned To: | matt |
|---|
| Fix Version: | 1.3.4 (SVN: v10824) |
|---|
| Update Notification: | |
|---|
Trouble Report Files:
Trouble Report Comments:
| |
| #1 | greg.ercolano
11:14 Oct 25, 2013 |
| A few bugaboos:
o Let's disable "Esc" from closing windows.
This drives people who use VI crazy, because they're in the habit
of (1) entering code, (2) Hitting Esc, (3) typing :w to save.
In VI these actions save the code typed,
in fluid it /dumps/ the code typed.
Or at very least, a dialog warning that defaults to Keep Editing..
o A way to add comments to widgets (the same way we have
for functions, classes, code->declaration, etc.)
o Fix Tab navigation in "Declaration Properties" so that Tab key
moves focus from the code -> comment -> OK -> Cancel. (Currently
it skips over 'Comment')
o Save code window size preference either project or user's home dir.
(Default code window size is always too small)
o Add subtle color coding for "ledgering" and possibly even
color coding of different code types (classes, funcs)
See attached "ledger.png"
o External text editor option.
Should at least prevent multiple edits on same code.
Should probably use threads to fire off editor, and when
editor completes, apply changes using a global lock.
Tree window should still be scrollable while edit(s) are in progress.
On close or compile, should warn if any unsaved editors are still open.
(Multiple editors open on different code should be OK, as long as
they're all closed before Alt-G, Alt-S, etc)
Use temp files that are named appropriately to the code being
edited, so that the editor's window title gives a hint which code
is being edited.
I think mingodad has a patch already in STR#2794,
not sure if he implemented it this way.
o I'm probably forgetting a few things.. | |
| |
| #2 | greg.ercolano
17:33 Oct 27, 2013 |
| > Let's disable "Esc" from closing windows.
Fixed in r10010. | |
| |
| #3 | matt
20:29 Apr 01, 2015 |
| The Declaration Dialog skips the Comments field on Tab navigation, because, as a text input field, the Comments widget hogs the Tab key events, and you can no longer navigate to OK and Cancel.
Maybe it would be smart to make input fields not grab Tab when navigating, only when they were clicked, or another character was entered first?
Alternatively, Alt_Tab could be made to work instead. Shift-Tab does already work to navigate backwards. | |
| |
| #4 | matt
10:21 Apr 02, 2015 |
| > A way to add comments to widgets (the same way we have for functions, classes, code->declaration, etc.)
Done in 11240. All Widgets can have comments now.
Code and Code Blocks can not, but that doesn't seem to make too much sense. | |
| |
| #5 | matt
10:22 Apr 02, 2015 |
| Navigation is fixed in 11239 | |
| |
| #6 | matt
04:33 Apr 04, 2015 |
| As for remembering the window sizes and positions: you can switch that on in Edit->GUI_Settings. It works for the code window as well. | |
| |
| #7 | matt
04:35 Apr 04, 2015 |
| I am against ledgering. Ledgering is useful if you have a huge gap between the first column and the following columns, and you don;t want to loose the line while going from left to right. In Fluid, there is no data following the Type and Name of the Widget, so it simply isn't need. I personally find it rather distracting. | |
| |
| #8 | matt
04:37 Apr 04, 2015 |
| I will close this bug now, moving the request for an external editor into a new STR. It's a very long standing request though, and nobody has found a safe solution yet. | |
| |
| #9 | matt
04:38 Apr 04, 2015 |
| Waiting for a reply on the ledger first ;-) | |
| |
| #10 | AlbrechtS
04:39 Jul 14, 2015 |
| As for external editor: see STR #3213
http://www.fltk.org/str.php?L3213
On ledgering: I can live w/o it, and I tend to agree with Matt that it can be distracting. However, besides the "following the line" aspect I see another advantage in better grouping of multi-line items, such as "GUI vs. console mode" and the following line in the 3rd item in the posted ledger.png file.
@Greg: AFAICT all issues except ledgering have been solved or moved to another STR (external editor issue). I suggest to close this STR and to open another STR for the ledgering issue if you still want to pursue this issue. | |
| |
| #11 | greg.ercolano
09:45 Jul 14, 2015 |
| Fine on no ledgering..
Though I'd offer there should be /some/ way to clarify grouping of functions+comments and classes, perhaps connector lines or some such.
Sometimes rows contain two lines of text, sometimes one depending on the presence of comments.. so there should be something visual (like subtle connector lines at the left or some such) to infer grouping.
Ideas I can think of:
o More vertical spacing between separate items
o Connector lines at the left (I think some modern IDEs do this)
o Icons that stretch or better represent one line vs. two
Also, a way to differentiate global scope definitions from functions/classes/main. It's hard to find the tops of classes in all the data and functions. Scanning for the little icons is difficult. ("What's the icon for "classes" again?") The icon shapes seem too subtle for visual searches.. maybe a little bit of subtle color in the icons could help that.
I don't use IDE's and visual code editors other than VI much at all, but I imagine there's some good examples out there, like sublime, VS, etc. | |
| |
| #12 | AlbrechtS
05:40 Jul 17, 2015 |
| I uploaded two images: line_full.png and line_short.png.
The difference is only the separator line's position and width (full width starting at the left border, short line starting right of the icon).
See attached patch separator_line.diff. The patch is only a proof of concept. Is this something we could use? If yes, which one?
Note that this is not fully tested, and I wonder if we should not draw the separator below the last item, but this is maybe somewhat more complicated. Currently I wouldn't know how to determine if the item is the last. We might need another parameter in Widget_Browser::item_draw(void *v, int X, int Y, int, int) or maybe a global variable.
I'd be fine with both variants. Maybe I'd prefer the short version, but I'm open for all suggestions and comments. | |
| |
| #13 | AlbrechtS
09:58 Jul 17, 2015 |
| @Greg: My patch was intended as a proof of concept and fixes only one issue you mentioned:
o More vertical spacing between separate items
by adding 3 pixels height and filling it with a one px light gray line.
Connector lines may be possible as well (not much more complicated), but they might be not so easy to follow, given the existing horizontal spacing.
Bigger icons, changing the icons etc. seems more involved. Something someone who has more designer capabilities should do.
If you agree I'll wait for votes in fltk.coredev (new thread: "RFC: fluid ledgering or separator lines or ...") and if we can get consensus I'm willing to commit the "separator line" patch with appropriate adjustments. At least as a first step. Further improvements should be done later, and I really believe that this should be a different STR (if needed). | |
| |
| #14 | AlbrechtS
12:11 Aug 01, 2015 |
| Fixed in Subversion repository.
svn r 10824 adds light gray separator lines to the fluid widget browser, as proposed in the recent patch. I restructured the patch slightly and fixed a few comments as well.
Greg, we should /really/ close this STR now, since this will likely be the last fix (related to this STR) in FLTK 1.3.4. I'm leaving it open though so we don't lose the comments.
I suggest that you open a new RFE (1.4-feature) if you want to pursue the remaining issues. Otherwise we should close this one w/Resolution.
Okay? | |
| |
| #15 | AlbrechtS
07:47 Feb 29, 2016 |
| @Greg: ping ? Trying to clean up STR's for release 1.3.4
Can we close this STR?
Do you want to reopen another one (1.4-feature) for the remaining issues, if any ? | |
| |
| #16 | greg.ercolano
10:31 Feb 29, 2016 |
| Fixed in Subversion repository.
Looks good, I'll close it for Matt (thanks Matt + Albrecht for mods!)
Anything remaining I'll move to another STR.
Just to see where we are; I confirmed these are done:
o (DONE/r?) Let's disable "Esc" from closing windows.
o (DONE/r11240) A way to add comments to widgets
o (DONE/r11239) Fix Tab navigation in "Declaration Properties"..
o (DONE/r10824) Add subtle color "ledgering"..
And these perhaps still pending; I'll open a new STR if need be:
o Save code window size preference..
Comment #6 says it works, but can't confirm width/height saved;
Still defaults to 71 cols x 7 lines after restarting fluid.
o External text editor option.
I understand this has moved to another STR. | |
[ Return to Bugs & Features ]
|
| |
