| | [ Return to Bugs & Features | SVN ⇄ GIT ]
STR #3125
| Application: | FLTK Library |
|---|
| Status: | 2 - Closed w/o Resolution |
|---|
| Priority: | 3 - Moderate, e.g. unable to compile the software |
|---|
| Scope: | 3 - Applies to all machines and operating systems |
|---|
| Subsystem: | None |
|---|
| Summary: | fltk-3: jerror.c: #include "jerror.h" should be #include "fltk3jpeg/jerror.h"? |
|---|
| Version: | 3.0 |
|---|
| Created By: | gabriele |
|---|
| Assigned To: | matt |
|---|
| Fix Version: | Unassigned |
|---|
| Update Notification: | |
|---|
Trouble Report Files:
No files
Trouble Report Comments:
| |
| #1 | gabriele
02:07 Sep 03, 2014 |
| hello,
apologies if I am missing some blatant point here
I am on GNU/linux
It seems to me that jerror.c (fltk-3) should be patched as per the following:
diff -c src/fltk3jpeg/jerror.c.FIX_JERROR_C src/fltk3jpeg/jerror.c
*** src/fltk3jpeg/jerror.c.FIX_JERROR_CWed Sep 3 10:28:08 2014
--- src/fltk3jpeg/jerror.cWed Sep 3 10:28:08 2014
***************
*** 22,28 ****
#include "fltk3jpeg/jinclude.h"
#include "fltk3jpeg/jpeglib.h"
#include "fltk3jpeg/jversion.h"
! #include "jerror.h"
#ifdef USE_WINDOWS_MESSAGEBOX
#include <windows.h>
--- 22,28 ----
#include "fltk3jpeg/jinclude.h"
#include "fltk3jpeg/jpeglib.h"
#include "fltk3jpeg/jversion.h"
! #include "fltk3jpeg/jerror.h"
#ifdef USE_WINDOWS_MESSAGEBOX
#include <windows.h>
***************
*** 48,54 ****
#define JMESSAGE(code,string)string ,
const char * const jpeg_std_message_table[] = {
! #include "jerror.h"
NULL
};
--- 48,54 ----
#define JMESSAGE(code,string)string ,
const char * const jpeg_std_message_table[] = {
! #include "fltk3jpeg/jerror.h"
NULL
};
As a matter of fact, without patching I get the following build error (which was
exposed after upgrading to libjpeg-turbo-1.3.90):
/usr/local/include/jerror.h:137:1: error: 'JCOPYRIGHT_SHORT' undeclared here (not in a function)
JMESSAGE(JMSG_COPYRIGHT, JCOPYRIGHT_SHORT)
^
What I seem to understand is that using '#include "jerror.h"' fails to
include the fltk private jerror.h header and instead picks the system
wide available one (from libjpeg-turbo, in my case): since this has
changed in libjpeg-turbo-1.3.90, I get the compile error (after
building fltk-3 without problems for a long time vs
libjpeg-turbo-1.3.[01]).
The above patch fixes everything for me
thanks a lot for maintaining and making publicly available fltk
ciao
gabriele | |
| |
| #2 | AlbrechtS
18:01 Sep 18, 2014 |
| Please note that FLTK 3.0 is in pre-alpha state and currently not maintained.
Do not use FLTK 3.0 for real projects - use FLTK 1.3 instead. | |
| |
| #3 | gabriele
23:16 Sep 18, 2014 |
| Thanks: I now notice that development of 3.0 is inactive since sep 2013; I build regularly (and in a largely unattended way) fltk-3.0 (along w/ fltk-1) and never found a problem: so, I though I could contribute my 5 cents on this occasion... | |
[ Return to Bugs & Features ]
|
| |
