FLTK logo

STR #3183

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 Home  |  Articles & FAQs  |  Bugs & Features  |  Documentation  |  Download  |  Screenshots  ]
 

Return to Bugs & Features | Roadmap 1.3 | SVN ⇄ GIT ]

STR #3183

Application:FLTK Library
Status:1 - Closed w/Resolution
Priority:2 - Low, e.g. a documentation error or undocumented side-effect
Scope:3 - Applies to all machines and operating systems
Subsystem:Core Library
Summary:Missing and potentially wrong box types in gleam scheme.
Version:1.3.3
Created By:AlbrechtS
Assigned To:AlbrechtS
Fix Version:1.3.4 (SVN: v10543)
Update Notification:

Receive EMails Don't Receive EMails

Trouble Report Files:

No files


Trouble Report Comments:


Name/Time/Date Text  
 
#1 AlbrechtS
05:42 Jan 29, 2015
FL/Enumerations.H and src/fl_boxtypes.cxx are out of sync since commit of the "gleam scheme" patch. The gleam box types are missing in src/fl_boxtypes.cxx.

I committed a patch from Dmitrij's oxy patch (STR #2675) to add the missing boxtype definitions. See svn r 10539.

However, there are some naming conflicts in this version - I don't know yet which one is correct:

Enum in FL/Enumerations.H  vs.  comment in src/fl_boxtypes.c:

  _FL_GLEAM_THIN_UP_BOX    vs.  _FL_GLEAM_THIN_UP_FRAME
  _FL_GLEAM_THIN_DOWN_BOX  vs.  _FL_GLEAM_THIN_DOWN_FRAME

The code in src/fl_boxtype.cxx seems to indicate that these are actually
frame (not box) types. This should be checked.

The worst case would be if we needed to rename the types in the enum. If it is a FRAME type, then it should be called *_FRAME, and if it is a BOX type (with background), it should be called *_BOX.
 
 
#2 AlbrechtS
17:25 Jan 30, 2015
Fortunately only the comment was wrong. I also "fixed" the box drawing function initialization, which doesn't really matter, because it's overwritten later.  
     

Return to Bugs & Features ]

 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.