| | [ Return to Bugs & Features | Roadmap 1.3 | SVN ⇄ GIT ]
STR #3037
| Application: | FLTK Library |
|---|
| Status: | 1 - Closed w/Resolution |
|---|
| Priority: | 2 - Low, e.g. a documentation error or undocumented side-effect |
|---|
| Scope: | 3 - Applies to all machines and operating systems |
|---|
| Subsystem: | Image Support |
|---|
| Summary: | multiple deprecations in built-in zlib |
|---|
| Version: | 1.3-current |
|---|
| Created By: | AnyCPU |
|---|
| Assigned To: | AlbrechtS |
|---|
| Fix Version: | 1.3.4 (SVN: v10624) |
|---|
| Update Notification: | |
|---|
Trouble Report Files:
No files
Trouble Report Comments:
| |
| #1 | AnyCPU
14:00 Jan 25, 2014 |
| has been explicitly marked deprecated:
lseek, close, write
If possible should be ISO's: _lseek, _close, _write | |
| |
| #2 | ianmacarthur
01:37 May 01, 2014 |
| I suspect this one is a bit "won't fix" as we want to track the imported libs.
I'd imagine this might "fix" itself next time we iterate the bundled version of zlib et al? | |
| |
| #3 | AnyCPU
09:48 May 01, 2014 |
| In general I left this for history reasons because Microsoft sometime can be not predicable. | |
| |
| #4 | AlbrechtS
16:12 Sep 18, 2014 |
| Hmm, scope is "3 - Applies to all machines and operating systems", but #3 mentions Microsoft explicitly. I thought (and I read lots of comments about this in the FLTK code) that this is a Microsoft-specific way to prepend '_' to the so-called (?) ISO functions.
See also this link:
http://lists.apple.com/archives/xcode-users/2011/Jan/msg00018.html
I would prefer not to use even more of these macros we discussed recently that are also mentioned in the article linked above, like
#ifdef _WIN32
#define stat _stat
#endif
So, who does really know what this is all about? If it is only a warning in MS compilers, can this warning be suppressed? | |
| |
| #5 | AlbrechtS
11:39 Jul 17, 2015 |
| I believe this issue is solved since the upgrade of zlib from version 1.2.5 to 1.2.8 on 16 Mar 2015 (svn r 10624).
I can't test it, but I see:
$ grep -i -n -5 _close zlib/*.[chH]
zlib/gzguts.h-37-
zlib/gzguts.h-38-#ifdef WINAPI_FAMILY
zlib/gzguts.h-39-# define open _open
zlib/gzguts.h-40-# define read _read
zlib/gzguts.h-41-# define write _write
zlib/gzguts.h:42:# define close _close
zlib/gzguts.h-43-#endif
zlib/gzguts.h-44-
...
This should fix the issue for close and write.
]$ grep -i -n -5 lseek zlib/*.[chH]
zlib/gzlib.c-4- */
zlib/gzlib.c-5-
zlib/gzlib.c-6-#include "gzguts.h"
zlib/gzlib.c-7-
zlib/gzlib.c-8-#if defined(_WIN32) && !defined(__BORLANDC__)
zlib/gzlib.c:9:# define LSEEK _lseeki64
zlib/gzlib.c-10-#else
zlib/gzlib.c-11-#if defined(_LARGEFILE64_SOURCE) && _LFS64_LARGEFILE-0
zlib/gzlib.c:12:# define LSEEK lseek64
zlib/gzlib.c-13-#else
zlib/gzlib.c:14:# define LSEEK lseek
zlib/gzlib.c-15-#endif
zlib/gzlib.c-16-#endif
This ought to fix the issue for lseek.
Can you confirm that the warnings are gone? If not, please specify exactly which version of compiler and toolchain, and show exact warnings.
Otherwise this STR will be closed in a few days. | |
| |
| #6 | AlbrechtS
06:13 Jul 30, 2015 |
| This STR has not been updated by the submitter for two or more weeks and has been closed as required by the FLTK Configuration Management Plan. If the issue still requires resolution, please re-submit a new STR. | |
[ Return to Bugs & Features ]
|
| |
